Add option to require contact via HS form for create/upgrade of team type #4343
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4343 +/- ##
==========================================
- Coverage 78.19% 78.17% -0.02%
==========================================
Files 292 292
Lines 13458 13430 -28
Branches 3012 3010 -2
==========================================
- Hits 10523 10499 -24
+ Misses 2935 2931 -4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
Is "Free" an appropriate pricing offer there? |
|
@joepavitt that's just how I happen to have my teams configured locally as part of validating all the different options. It isn't a reflection of the changes in this PR |
joepavitt
approved these changes
Aug 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4317
Adds option on TeamType configuration to require users contact us, rather than allow self-service creation/upgrade to that type.
TeamType config
If the Require contact to upgrade option is selected, hubspot portal/form ids can be provided.
UX
When creating a new team, or changing an existing team type, if they select a type that has been configured to require contact, they are shown this:
This only applies to non-admin users. If the user is an admin, then can select the type and create the team 'normally'.
Hubspot
When clicking the 'contact sales' button, the configured hubspot form is submitted with the user's email and the details of the page they are on. The HS form can be then configured to trigger whatever business process is required.
I have created a suitable form in HS already called 'Enterprise Upgrade Request'.