Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add explicit PH event for verification #4344

Merged
merged 1 commit into from
Aug 8, 2024
Merged

Add explicit PH event for verification #4344

merged 1 commit into from
Aug 8, 2024

Conversation

joepavitt
Copy link
Contributor

Description

  • If a user presses <enter> on the verification code, it's very difficult to reliably track that in PH as we have no unique form identifier, or unique URL for the verification form.
  • The other challenge with relying on the autocapture events is that even if an incorrect code is submitted, we still register the click as a successful "verify"
  • A cleaner way to handle this is have an explicit event called when the API responds successfully, which this PR adds

@joepavitt joepavitt requested a review from knolleary August 7, 2024 15:54
Copy link

codecov bot commented Aug 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.17%. Comparing base (ef94197) to head (13f6190).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4344   +/-   ##
=======================================
  Coverage   78.17%   78.17%           
=======================================
  Files         292      292           
  Lines       13430    13430           
  Branches     3010     3010           
=======================================
  Hits        10499    10499           
  Misses       2931     2931           
Flag Coverage Δ
backend 78.17% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@joepavitt joepavitt merged commit cff3adf into main Aug 8, 2024
14 checks passed
@joepavitt joepavitt deleted the ph-event-verified branch August 8, 2024 07:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants