Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix lingering active tab when navigating back #4350

Merged
merged 1 commit into from
Aug 8, 2024

Conversation

cstns
Copy link
Contributor

@cstns cstns commented Aug 8, 2024

Description

Fixed lingering active tab when navigating back.

Related Issue(s)

closes #4022

Checklist

  • I have read the contribution guidelines
  • Suitable unit/system level tests have been added and they pass
  • Documentation has been updated
    • Upgrade instructions
    • Configuration details
    • Concepts
  • Changes flowforge.yml?
    • Issue/PR raised on FlowFuse/helm to update ConfigMap Template
    • Issue/PR raised on FlowFuse/CloudProject to update values for Staging/Production

Labels

  • Includes a DB migration? -> add the area:migration label

@cstns cstns self-assigned this Aug 8, 2024
@cstns cstns requested a review from joepavitt August 8, 2024 12:03
Copy link

codecov bot commented Aug 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.17%. Comparing base (552a608) to head (88632dc).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4350   +/-   ##
=======================================
  Coverage   78.17%   78.17%           
=======================================
  Files         292      292           
  Lines       13430    13430           
  Branches     3010     3010           
=======================================
  Hits        10499    10499           
  Misses       2931     2931           
Flag Coverage Δ
backend 78.17% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@joepavitt joepavitt merged commit 0fe1c4c into main Aug 8, 2024
14 checks passed
@joepavitt joepavitt deleted the 4022_fix-lingering-active-tag branch August 8, 2024 12:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Page tabs show 2 items selected when history back is operated
2 participants