-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Product Tour - Welcome to FlowFuse #4383
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4383 +/- ##
=======================================
Coverage 78.33% 78.33%
=======================================
Files 293 293
Lines 13567 13567
Branches 3052 3052
=======================================
Hits 10628 10628
Misses 2939 2939
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we not be conditioning the tour or adapting to what is present in the team?
Also, is this intended for FFC or FFD also?
Because while we do auto create an application and instance, FFD might not 🤷
As an example, a user joining an existing team and signing in for the first time, when they access the existing team that has no instances or does have devices - it throws off the dialog.
Great point re: dedicated and joining existing teams... I'll adjust it accordingly. May need to be conditional (not sure how yet) on that last "Open Editor" step. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@gstout52 FYI - tour script is here if you want to review. @Steve-Mcl made great points that we need to make this host agnostic, so this covers all hosting options quite nicely, and even for new users coming into an existing team, full of resources.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agnostic language reads better. I feel this can support varying setups.
@joepavitt I wont merge until @gstout52 has had a chance to read and review. |
Co-authored-by: Greg Stoutenburg <87526457+gstout52@users.noreply.github.com>
Description
Related Issue(s)
Closes #2721
Checklist
Screen.Recording.2024-08-15.at.15.40.10.mov