Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Send notification to inviter when a team invite is accepted #4385

Merged
merged 3 commits into from
Aug 16, 2024

Conversation

joepavitt
Copy link
Contributor

@joepavitt joepavitt commented Aug 15, 2024

Description

  • Records a notification for the inviter when the invitee accepts an invitation as a new team-invite-accepted-invitor type
  • Adds relevant .vue components to display the notification, which navigates to the team member's page when clicked.
Screenshot 2024-08-15 at 20 10 34

Not sure what tests, if any, need to be added here?

Related Issue(s)

Closes #4379

Checklist

Copy link

codecov bot commented Aug 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.34%. Comparing base (1818cf0) to head (a8931c1).
Report is 4 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4385   +/-   ##
=======================================
  Coverage   78.33%   78.34%           
=======================================
  Files         293      293           
  Lines       13567    13571    +4     
  Branches     3052     3052           
=======================================
+ Hits        10628    10632    +4     
  Misses       2939     2939           
Flag Coverage Δ
backend 78.34% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Steve-Mcl
Copy link
Contributor

@joepavitt want this merged now?

@joepavitt
Copy link
Contributor Author

Yep, I was just waiting for those UI Tests to pass - I'll merge - thanks Steve

@joepavitt joepavitt merged commit dfac073 into main Aug 16, 2024
14 checks passed
@joepavitt joepavitt deleted the 4379-invitor-notification branch August 16, 2024 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Notify team inviter when an invitation is accepted
3 participants