Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change editor & dashboard buttons to anchors #4396

Merged
merged 9 commits into from
Aug 23, 2024

Conversation

Steve-Mcl
Copy link
Contributor

@Steve-Mcl Steve-Mcl commented Aug 23, 2024

closes #4355

Description

  • Adds type="anchor" support to ff-button
  • Changes the dashboard button to type anchor
  • Changes the editor button to type anchor but still supports left click into immersive mode

NOTE: 3 tests using should('be.disabled') needed to be changed to test for attr disabled instead. See cypress-io/cypress#5903

NOTE: The new anchor operates exactly like the old button.

  • If Left Clicking "Editor" and it is immersive ready, it will be shown immersive however, if the user middle clicks or right clicks, the editor can be opened in a new tab (as per browser behaviour)
  • Left clicking the dashboard opens as a new tab as it always did (targeted to a specific target to prevent multiple windows) however now it isa n anchor, middle click and right click can open another instance in a new tab (as per browser behaviour)

Related Issue(s)

#4355

Checklist

  • I have read the contribution guidelines
  • Suitable unit/system level tests have been added and they pass
  • Documentation has been updated
    • Upgrade instructions
    • Configuration details
    • Concepts
  • Changes flowforge.yml?
    • Issue/PR raised on FlowFuse/helm to update ConfigMap Template
    • Issue/PR raised on FlowFuse/CloudProject to update values for Staging/Production

Labels

  • Includes a DB migration? -> add the area:migration label

Copy link

codecov bot commented Aug 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.34%. Comparing base (dd070d7) to head (c9fb9e5).
Report is 38 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4396   +/-   ##
=======================================
  Coverage   78.34%   78.34%           
=======================================
  Files         293      293           
  Lines       13571    13571           
  Branches     3052     3052           
=======================================
  Hits        10632    10632           
  Misses       2939     2939           
Flag Coverage Δ
backend 78.34% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@joepavitt joepavitt merged commit 33389ca into main Aug 23, 2024
14 checks passed
@joepavitt joepavitt deleted the 4355-editor-dashboard-buttons-as-anchors branch August 23, 2024 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Buttons as Links so there is a choice to open in new tab\window
2 participants