Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add UI updates for Team Suspend action #4451

Merged
merged 3 commits into from
Sep 5, 2024

Conversation

knolleary
Copy link
Member

Adds UI elements to support suspending a team.

Suspend Team option added to Team Settings/Danger

image

Confirm suspend dialog

image

Suspended banner

Once suspended, shows banner:

image

Reactivate team on Team Settings

image

Alternatively, setting up billing again will unsuspend the team.

Copy link

codecov bot commented Sep 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.12%. Comparing base (faaf8d1) to head (517da38).
Report is 4 commits behind head on 4438-add-suspended-state.

Additional details and impacted files
@@                    Coverage Diff                    @@
##           4438-add-suspended-state    #4451   +/-   ##
=========================================================
  Coverage                     78.12%   78.12%           
=========================================================
  Files                           296      296           
  Lines                         14071    14071           
  Branches                       3176     3176           
=========================================================
  Hits                          10993    10993           
  Misses                         3078     3078           
Flag Coverage Δ
backend 78.12% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@knolleary
Copy link
Member Author

👀 ui test failures

Steve-Mcl
Steve-Mcl previously approved these changes Sep 5, 2024
@Steve-Mcl Steve-Mcl self-requested a review September 5, 2024 12:02
@knolleary
Copy link
Member Author

UX tests fixed and added simple ux test for basic suspend/resume cycle.

Copy link
Contributor

@Steve-Mcl Steve-Mcl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved. waiting final test finish before merge

@Steve-Mcl
Copy link
Contributor

Steve-Mcl commented Sep 5, 2024

"Tests / Backend tests (18.x) (pull_request) In progress — This check has started... " taking waaaay to long.

Noticed this in the details...

  1) Pipelines API
       Don't overwrite fields
         keep title:
     Validation error
  Error
      at Database.<anonymous> (node_modules/sequelize/lib/dialects/sqlite/query.js:185:27)
      at /home/runner/work/flowfuse/flowfuse/node_modules/sequelize/lib/dialects/sqlite/query.js:183:50
      at new Promise (<anonymous>)
      at Query.run (node_modules/sequelize/lib/dialects/sqlite/query.js:183:12)
      at /home/runner/work/flowfuse/flowfuse/node_modules/sequelize/lib/sequelize.js:315:28
      at async SQLiteQueryInterface.insert (node_modules/sequelize/lib/dialects/abstract/query-interface.js:308:21)
      at async model.save (node_modules/sequelize/lib/model.js:2490:35)
      at async ProjectTemplate.create (node_modules/sequelize/lib/model.js:1362:12)
      at async TestModelFactory.createProjectTemplate (test/lib/TestModelFactory.js:115:26)
      at async Context.<anonymous> (test/unit/forge/ee/routes/api/pipeline_spec.js:2922:35)

Nevermind - was an inline output (nothing to see here)

@Steve-Mcl Steve-Mcl merged commit f05d5eb into 4438-add-suspended-state Sep 5, 2024
14 checks passed
@Steve-Mcl Steve-Mcl deleted the 4438-suspended-ux branch September 5, 2024 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants