Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle team with inactive team-type when viewing change-type #4464

Merged
merged 4 commits into from
Sep 10, 2024

Conversation

knolleary
Copy link
Member

Fixes #4463

Description

The changeType component assumed the current team's type would be in the list of active team types retrieved from the backend.

However, if the current team's type was inactive, then it wouldn't be in the response - and this.input.teamType would end up being null - causing various breakage of the page.

This fixes it by reverting to this.team.type if necessary. It also adds a message to the form to let the user know their current type is unavailable.

Copy link

codecov bot commented Sep 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.13%. Comparing base (19bbc15) to head (dfa35f2).
Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4464   +/-   ##
=======================================
  Coverage   78.13%   78.13%           
=======================================
  Files         296      296           
  Lines       14119    14119           
  Branches     3189     3189           
=======================================
  Hits        11032    11032           
  Misses       3087     3087           
Flag Coverage Δ
backend 78.13% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

frontend/src/pages/team/changeType.vue Outdated Show resolved Hide resolved
Co-authored-by: Costin Serban <cstn.serban@gmail.com>
@knolleary knolleary merged commit 6e3cad8 into main Sep 10, 2024
14 checks passed
@knolleary knolleary deleted the 4463-upgrade-from-inactive-team-type branch September 10, 2024 09:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change Team Type view is blank if current team type is inactive
2 participants