Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Asset upload dialog #4465

Merged
merged 2 commits into from
Sep 9, 2024
Merged

fix: Asset upload dialog #4465

merged 2 commits into from
Sep 9, 2024

Conversation

Steve-Mcl
Copy link
Contributor

closes #4456
closes #4458

Description

Fixes asset upload

  • clear 5mb warning when selecting file < 5mb
  • clear input value to permit same file selection

Related Issue(s)

#4456
#4458

Checklist

  • I have read the contribution guidelines
  • Suitable unit/system level tests have been added and they pass
  • Documentation has been updated
    • Upgrade instructions
    • Configuration details
    • Concepts
  • Changes flowforge.yml?
    • Issue/PR raised on FlowFuse/helm to update ConfigMap Template
    • Issue/PR raised on FlowFuse/CloudProject to update values for Staging/Production

Labels

  • Includes a DB migration? -> add the area:migration label

Copy link

codecov bot commented Sep 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.13%. Comparing base (d2c80ee) to head (8cff2c2).
Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4465   +/-   ##
=======================================
  Coverage   78.13%   78.13%           
=======================================
  Files         296      296           
  Lines       14119    14119           
  Branches     3189     3189           
=======================================
  Hits        11032    11032           
  Misses       3087     3087           
Flag Coverage Δ
backend 78.13% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Steve-Mcl Steve-Mcl merged commit 33308ad into main Sep 9, 2024
14 checks passed
@Steve-Mcl Steve-Mcl deleted the asset-upload-improvements branch September 9, 2024 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants