-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve user feedback when developer mode change fails #4469
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4469 +/- ##
=======================================
Coverage 78.12% 78.12%
=======================================
Files 296 296
Lines 14125 14125
Branches 3189 3189
=======================================
Hits 11035 11035
Misses 3090 3090
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Why show different messages for these two cases? For the user, its the same fact - they aren't allowed to do it. The underlying reason may be subtly different, but the proposed text doesn't make that difference obvious (and nor should it IMHO). But also, shouldn't we be able to know ahead of time the user isn't allowed to do the action - and thus we shouldn't have let them try in the first place? |
👍 for this
and this actually. |
|
closes #4468
Description
Presents a friendlier toast than "Request failed with status code 403"
Now displays relevant toast text with a fall back to a friendlier message if the error is generic or unrecognised.
Related Issue(s)
#4468
Checklist
flowforge.yml
?FlowFuse/helm
to update ConfigMap TemplateFlowFuse/CloudProject
to update values for Staging/ProductionLabels
area:migration
label