4461 add file asset service visibility selector #4472

cstns · 2024-09-10T08:32:08Z

Description

add file asset service visibility selector and integrate it with the existing api
added a new key on the staticAsset api to include the current folder
added the url column in the files list
added alerts

Related Issue(s)

branched out of #4473
closes #4461

Checklist

I have read the contribution guidelines
Suitable unit/system level tests have been added and they pass
Documentation has been updated
- Upgrade instructions
- Configuration details
- Concepts
Changes flowforge.yml?
- Issue/PR raised on FlowFuse/helm to update ConfigMap Template
- Issue/PR raised on FlowFuse/CloudProject to update values for Staging/Production

Labels

Includes a DB migration? -> add the area:migration label

…er metadata , remove currentDirectory,

… the breadcrumbs should be ignored due to how the relative path is resolved

…der visibility

…d-file-asset-service-visibility-selector

…ate after successful visibility update in order to not confuse users

…d-file-asset-service-visibility-selector

cstns · 2024-09-10T08:37:57Z

Mobile is not yet optimized

codecov · 2024-09-10T08:46:23Z

Codecov Report

Attention: Patch coverage is 90.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 78.14%. Comparing base (5dbdd3f) to head (0be3bd3).
Report is 33 commits behind head on 4449_add-a-directory-navigation-component.

Files with missing lines	Patch %	Lines
forge/ee/routes/staticAssets/index.js	90.00%	1 Missing ⚠️

Additional details and impacted files

@@                            Coverage Diff                             @@
##           4449_add-a-directory-navigation-component    #4472   +/-   ##
==========================================================================
  Coverage                                      78.13%   78.14%           
==========================================================================
  Files                                            296      296           
  Lines                                          14119    14129   +10     
  Branches                                        3189     3192    +3     
==========================================================================
+ Hits                                           11032    11041    +9     
- Misses                                          3087     3088    +1

Flag	Coverage Δ
backend	`78.14% <90.00%> (+<0.01%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

…nto 4461_add-file-asset-service-visibility-selector

…bility-selector' into 4461_add-file-asset-service-visibility-selector

frontend/src/components/file-browser/cells/FilePath.vue

hardillb · 2024-09-10T14:41:39Z

frontend/src/components/file-browser/cells/FilePath.vue

            // clear leading slash
            return path.replace(/^\//, '')


I assume this is where the leading slash is being removed.

…ying file paths

hardillb · 2024-09-11T08:42:56Z

We have double slashes in the URLs

hardillb · 2024-09-11T08:59:05Z

@cstns Sorry, I've just worked out why @joepavitt was using relative paths for files.

We can't use a standard /data/storage/ on LocalFS builds because the storage directory is going to be something like /opt/flowforge/var/projects/[project-id]/storage and we don't have an easy way to get that path in the UI.

So please revert my suggestion to have the full path for the Folder Path and the File Path both in what's displayed and when copied to the clip board. The paths should also not start with a leading / (which might fix the URLs having double / in the last comment).

Again sorry for making you change that earlier

cstns · 2024-09-11T09:04:30Z

Again sorry for making you change that earlier

No need to apologize, it's an easy revert.

Should I also revert the Base URL & File URL to relative paths or leave the fqdn as it is?

hardillb · 2024-09-11T09:41:30Z

No, leave the urls please

…ty change

hardillb

I'm saying this is good

hardillb · 2024-09-11T14:22:10Z

But it has UI test failures so not merging

cstns · 2024-09-11T14:22:45Z

looking over them as we speak

cstns added 18 commits September 6, 2024 17:07

add a updateVisibility api call

a9d136c

add a rough draft of the visibility selector

2003125

use the visibility selector

7686918

use the file breadcrumbs as source of truth and include all file/fold…

905bf79

…er metadata , remove currentDirectory,

display the baseUrl in the Folder breadcrumbs

38c72e5

rework the filePath path to take into account the baseUrl paths where…

548e4a3

… the breadcrumbs should be ignored due to how the relative path is resolved

add validation & styling to the visibilitySelector when selecting fol…

31e61a8

…der visibility

update the last directory in breadcrumbs to reflect visibility change

cda482e

set the BaseURL itemFilePath in the FileBrowser

cbe75c6

prevent setting an empty static file path

cc6fc1b

Merge branch '4449_add-a-directory-navigation-component' into 4461_ad…

3257c27

…d-file-asset-service-visibility-selector

Add the URL column in the files table

5e2d8bf

Add validation to the staticPFilePaths, disable current directory upd…

77b40e3

…ate after successful visibility update in order to not confuse users

Add the current folder options in the static asset get files api

104aad0

alter the assets client request to expose the folder payload

3ec7e00

alter the assets tab to reload the current folder on instance restart

7cc30d2

removed alert from improper place

12c2fd3

disable the folder breadcrumbs whilst the instance is loading

1b716fe

cstns self-assigned this Sep 10, 2024

cstns changed the base branch from main to 4449_add-a-directory-navigation-component September 10, 2024 08:35

cstns temporarily deployed to staging September 10, 2024 08:35 — with GitHub Actions Inactive

Merge branch '4449_add-a-directory-navigation-component' into 4461_ad…

284a78a

…d-file-asset-service-visibility-selector

cstns temporarily deployed to staging September 10, 2024 08:43 — with GitHub Actions Inactive

cstns added 2 commits September 10, 2024 12:04

Merge branch 'refs/heads/4449_add-a-directory-navigation-component' i…

7fb2c7f

…nto 4461_add-file-asset-service-visibility-selector

Merge remote-tracking branch 'origin/4461_add-file-asset-service-visi…

27c2c14

…bility-selector' into 4461_add-file-asset-service-visibility-selector

cstns temporarily deployed to staging September 10, 2024 09:08 — with GitHub Actions Inactive

add e2e tests

42148f1

cstns temporarily deployed to staging September 10, 2024 11:58 — with GitHub Actions Inactive

adding leading slash when copying file paths

ef7254f

cstns temporarily deployed to staging September 10, 2024 14:36 — with GitHub Actions Inactive

hardillb reviewed Sep 10, 2024

View reviewed changes

frontend/src/components/file-browser/cells/FilePath.vue Outdated Show resolved Hide resolved

hardillb reviewed Sep 10, 2024

View reviewed changes

cstns added 2 commits September 10, 2024 18:03

use and display the fully qualified path name when copying and displa…

e6e428a

…ying file paths

display the leading slash for filePaths and use the fqdn for baseUrl's

de8eccb

cstns temporarily deployed to staging September 10, 2024 15:46 — with GitHub Actions Inactive

rename baseUrl prop as it was conflicting with other props

d8a7b03

cstns temporarily deployed to staging September 11, 2024 08:19 — with GitHub Actions Inactive

revert leading slashes and prepending file paths

4fd5bfa

cstns temporarily deployed to staging September 11, 2024 11:45 — with GitHub Actions Inactive

cstns added 3 commits September 11, 2024 15:50

remove prepended value for the breadcrumbs folder path

90eb0f6

fix directory creation after single source of truth

6f76e9c

avoid base url double slashes by clearing leading slashes on visibili…

57757cb

…ty change

cstns temporarily deployed to staging September 11, 2024 13:30 — with GitHub Actions Inactive

styling

a4609b1

cstns temporarily deployed to staging September 11, 2024 13:41 — with GitHub Actions Inactive

hardillb approved these changes Sep 11, 2024

View reviewed changes

fix e2e tests

0be3bd3

cstns temporarily deployed to staging September 11, 2024 14:35 — with GitHub Actions Inactive

hardillb merged commit b7ada99 into 4449_add-a-directory-navigation-component Sep 11, 2024
14 checks passed

hardillb deleted the 4461_add-file-asset-service-visibility-selector branch September 11, 2024 15:20

hardillb temporarily deployed to staging September 11, 2024 15:20 — with GitHub Actions Inactive

cstns mentioned this pull request Sep 18, 2024

Add a share/visibility selector and integrate it with the current API #4461

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

4461 add file asset service visibility selector #4472

4461 add file asset service visibility selector #4472

cstns commented Sep 10, 2024 •

edited

Loading

cstns commented Sep 10, 2024

codecov bot commented Sep 10, 2024 •

edited

Loading

hardillb Sep 10, 2024

hardillb commented Sep 11, 2024

hardillb commented Sep 11, 2024

cstns commented Sep 11, 2024

hardillb commented Sep 11, 2024

hardillb left a comment

hardillb commented Sep 11, 2024

cstns commented Sep 11, 2024

4461 add file asset service visibility selector #4472

4461 add file asset service visibility selector #4472

Conversation

cstns commented Sep 10, 2024 • edited Loading

Description

Related Issue(s)

Checklist

Labels

cstns commented Sep 10, 2024

codecov bot commented Sep 10, 2024 • edited Loading

Codecov Report

hardillb Sep 10, 2024

Choose a reason for hiding this comment

hardillb commented Sep 11, 2024

hardillb commented Sep 11, 2024

cstns commented Sep 11, 2024

hardillb commented Sep 11, 2024

hardillb left a comment

Choose a reason for hiding this comment

hardillb commented Sep 11, 2024

cstns commented Sep 11, 2024

cstns commented Sep 10, 2024 •

edited

Loading

codecov bot commented Sep 10, 2024 •

edited

Loading