Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mitigate chat widget blocking elements #4477

Merged
merged 2 commits into from
Sep 14, 2024

Conversation

Steve-Mcl
Copy link
Contributor

closes #2897

Description

  • adjusts excessive padding on the div holding the chat bubble iframe

  • adds mb-14 (approx 56px) to bottom of lists containing RH kebab menu

before

light background added temporarily to demonstrate overlap
image

after

light background added temporarily to demonstrate overlap
image

Related Issue(s)

#2897

Checklist

  • I have read the contribution guidelines
  • Suitable unit/system level tests have been added and they pass
  • Documentation has been updated
    • Upgrade instructions
    • Configuration details
    • Concepts
  • Changes flowforge.yml?
    • Issue/PR raised on FlowFuse/helm to update ConfigMap Template
    • Issue/PR raised on FlowFuse/CloudProject to update values for Staging/Production

Labels

  • Includes a DB migration? -> add the area:migration label

Copy link

codecov bot commented Sep 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.12%. Comparing base (33308ad) to head (d620892).
Report is 16 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4477      +/-   ##
==========================================
- Coverage   78.13%   78.12%   -0.02%     
==========================================
  Files         296      296              
  Lines       14119    14125       +6     
  Branches     3189     3189              
==========================================
+ Hits        11032    11035       +3     
- Misses       3087     3090       +3     
Flag Coverage Δ
backend 78.12% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@joepavitt joepavitt merged commit e6d89c6 into main Sep 14, 2024
13 of 14 checks passed
@joepavitt joepavitt deleted the 2898-mitigate-chat-widget-blocking-elements branch September 14, 2024 11:24
@knolleary
Copy link
Member

knolleary commented Sep 16, 2024

On production we still have views that aren't usable at the bottom corn due to the chat widget.

For example, the TeamTypes admin view:

image

And despite the screenshots in the PR description, the iframe is still the large square - here I've used browser tools to draw its outline - nothing inside that square is clickable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to administer last device in list due to chat widget
3 participants