Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix remaining HS chat bubble issues #4504

Merged
merged 2 commits into from
Sep 17, 2024

Conversation

Steve-Mcl
Copy link
Contributor

closes #4502
closes #4488

Description

Related Issue(s)

#4502
#4488

Checklist

  • I have read the contribution guidelines
  • Suitable unit/system level tests have been added and they pass
  • Documentation has been updated
    • Upgrade instructions
    • Configuration details
    • Concepts
  • Changes flowforge.yml?
    • Issue/PR raised on FlowFuse/helm to update ConfigMap Template
    • Issue/PR raised on FlowFuse/CloudProject to update values for Staging/Production

Labels

  • Includes a DB migration? -> add the area:migration label

@Steve-Mcl Steve-Mcl linked an issue Sep 17, 2024 that may be closed by this pull request
@Steve-Mcl Steve-Mcl requested review from joepavitt and hardillb and removed request for joepavitt September 17, 2024 16:44
Copy link

codecov bot commented Sep 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.12%. Comparing base (89c270b) to head (63f5e02).
Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4504   +/-   ##
=======================================
  Coverage   78.12%   78.12%           
=======================================
  Files         296      296           
  Lines       14125    14125           
  Branches     3189     3189           
=======================================
  Hits        11035    11035           
  Misses       3090     3090           
Flag Coverage Δ
backend 78.12% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hardillb hardillb merged commit 2830e92 into main Sep 17, 2024
14 checks passed
@hardillb hardillb deleted the 4502-chat-window-on-flowfuse-cloud-is-obscured branch September 17, 2024 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Chat window on FlowFuse Cloud is obscured Some operations are obscured by HS chat bubble widget
2 participants