Store platform settings, teamMembership and team store values in localStorage #4507
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ssionStorage for teamMembership & team to preserve multiple tab navigation integrity
…a url link the team might not be loaded yet due to asynchronicity
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4507 +/- ##
=======================================
Coverage 78.30% 78.30%
=======================================
Files 302 302
Lines 14355 14355
Branches 3263 3263
=======================================
Hits 11240 11240
Misses 3115 3115
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Steve-Mcl
reviewed
Sep 18, 2024
…immersive-editor-first-page-load # Conflicts: # frontend/src/mixins/Features.js # frontend/src/pages/instance/Assets.vue
|
follow up to use the local copy of roles #4578 |
Steve-Mcl
reviewed
Sep 27, 2024
Steve-Mcl
reviewed
Sep 27, 2024
Steve-Mcl
approved these changes
Sep 27, 2024
cstns
deleted the
4459_empty-assets-on-immersive-editor-first-page-load
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Syncing the account store's
featuresin localStorage andteamMembershipandteamkeys in sessionStorage.Since the creation of the related bug, a new guard has been added in the assets tab on the mounted lifecycle hook that redirects unauthorized users (hasAMinimumTeamRoleOf('member')) to the instance overview page.
Given the async nature of the team, teamMembership and settings api calls which returns the data required to validate permissions, I'm automatically redirected to the instance overview page when accessing the immersive editor assets page.
If the guard were to be removed, the bug can be replicated.
I had to get a little bit creative with the route guard and data loading.
Related Issue(s)
closes #4459
Checklist
flowforge.yml?FlowFuse/helmto update ConfigMap TemplateFlowFuse/CloudProjectto update values for Staging/ProductionLabels
area:migrationlabel