Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add guards on PostHog API calls #4508

Merged
merged 2 commits into from
Sep 18, 2024
Merged

Add guards on PostHog API calls #4508

merged 2 commits into from
Sep 18, 2024

Conversation

hardillb
Copy link
Contributor

@hardillb hardillb commented Sep 18, 2024 •
edited
Loading

Description

Adds guards to all PostHog API calls

Related Issue(s)

#4503

Checklist

  • I have read the contribution guidelines
  • Suitable unit/system level tests have been added and they pass
  • Documentation has been updated
    • Upgrade instructions
    • Configuration details
    • Concepts
  • Changes flowforge.yml?
    • Issue/PR raised on FlowFuse/helm to update ConfigMap Template
    • Issue/PR raised on FlowFuse/CloudProject to update values for Staging/Production

Labels

  • Includes a DB migration? -> add the area:migration label

@hardillb hardillb requested a review from cstns September 18, 2024 09:33
@hardillb hardillb self-assigned this Sep 18, 2024
@hardillb hardillb changed the title Test guards on PostHog Add guards on PostHog API calls Sep 18, 2024
@knolleary knolleary merged commit dd04734 into main Sep 18, 2024
13 checks passed
@knolleary knolleary deleted the guard-post-hog branch September 18, 2024 09:46
@hardillb hardillb mentioned this pull request Sep 24, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@knolleary knolleary knolleary approved these changes

@cstns cstns Awaiting requested review from cstns

Assignees

@hardillb hardillb

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hardillb @knolleary