Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

handle new logout event from nr-editor #4544

Merged
merged 1 commit into from
Sep 23, 2024
Merged

Conversation

cstns
Copy link
Contributor

@cstns cstns commented Sep 23, 2024

Description

handle new logout event from nr-editor while in immersive view

Related Issue(s)

closes #4524

Checklist

  • I have read the contribution guidelines
  • Suitable unit/system level tests have been added and they pass
  • Documentation has been updated
    • Upgrade instructions
    • Configuration details
    • Concepts
  • Changes flowforge.yml?
    • Issue/PR raised on FlowFuse/helm to update ConfigMap Template
    • Issue/PR raised on FlowFuse/CloudProject to update values for Staging/Production

Labels

  • Includes a DB migration? -> add the area:migration label

@cstns cstns self-assigned this Sep 23, 2024
@cstns cstns requested a review from hardillb September 23, 2024 14:41
Copy link

codecov bot commented Sep 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.16%. Comparing base (5979e15) to head (841941d).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4544   +/-   ##
=======================================
  Coverage   78.16%   78.16%           
=======================================
  Files         300      300           
  Lines       14283    14283           
  Branches     3240     3240           
=======================================
  Hits        11165    11165           
  Misses       3118     3118           
Flag Coverage Δ
backend 78.16% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cstns cstns merged commit 56c64bb into main Sep 23, 2024
14 checks passed
@cstns cstns deleted the 4524_fix-immersive-editor-logout branch September 23, 2024 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Logging out from an instance using the immersive editor makes the editor drawer linger
2 participants