Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace the AssetCompareDialog, VisibilitySelector and Logs dropdowns #4580

Conversation

cstns
Copy link
Contributor

@cstns cstns commented Sep 27, 2024

Description

Replace the AssetCompareDialog, VisibilitySelector and Logs dropdowns

Related Issue(s)

close #4562

Checklist

  • I have read the contribution guidelines
  • Suitable unit/system level tests have been added and they pass
  • Documentation has been updated
    • Upgrade instructions
    • Configuration details
    • Concepts
  • Changes flowforge.yml?
    • Issue/PR raised on FlowFuse/helm to update ConfigMap Template
    • Issue/PR raised on FlowFuse/CloudProject to update values for Staging/Production

Labels

  • Includes a DB migration? -> add the area:migration label

@cstns cstns self-assigned this Sep 27, 2024
Copy link

codecov bot commented Sep 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.30%. Comparing base (a1cc1c5) to head (00197f4).
Report is 23 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4580   +/-   ##
=======================================
  Coverage   78.30%   78.30%           
=======================================
  Files         302      302           
  Lines       14360    14360           
  Branches     3265     3265           
=======================================
  Hits        11244    11244           
  Misses       3116     3116           
Flag Coverage Δ
backend 78.30% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@Steve-Mcl Steve-Mcl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice that we can now type to get to item and esc to close etc. however there are 2 small issues:

  1. The size of the dropdown does not have a min width AND/OR doesnt compute a min width from entries and so collapses to an unreadable narrow list when a short item is selected

selection 1 - it expands
image

selection 2 - it collapses
image

  1. The snapshot compare list contains empty rows

image

…lity-selector-and-logs-dropdowns' into 4562_replace-assetCompare-visibility-selector-and-logs-dropdowns
Steve-Mcl
Steve-Mcl previously approved these changes Sep 27, 2024
Copy link
Contributor

@Steve-Mcl Steve-Mcl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cstns
Functionally, I am now happy with this.

Code wise also good however I am curious about the CSS. In particular, the affect or potential impact of using such common class names like "option", "options" and "button" in the controls. Prior to this work, they were much less likely to be impacted by any stray CSS classes as they were more verbose e.g ff-dropdown-options.

Feel free to tell me this is nothing to worry about and proceed.

@Steve-Mcl Steve-Mcl dismissed their stale review September 30, 2024 09:38

issue with dialog css

@Steve-Mcl
Copy link
Contributor

Steve-Mcl commented Sep 30, 2024

Dismissed review until dialog header CSS fix is pushed

image

@cstns
Copy link
Contributor Author

cstns commented Sep 30, 2024

fix incoming, pending tests running locally

@Steve-Mcl Steve-Mcl merged commit f40f811 into main Oct 1, 2024
14 checks passed
@Steve-Mcl Steve-Mcl deleted the 4562_replace-assetCompare-visibility-selector-and-logs-dropdowns branch October 1, 2024 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants