-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace the AssetCompareDialog, VisibilitySelector and Logs dropdowns #4580
Replace the AssetCompareDialog, VisibilitySelector and Logs dropdowns #4580
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4580 +/- ##
=======================================
Coverage 78.30% 78.30%
=======================================
Files 302 302
Lines 14360 14360
Branches 3265 3265
=======================================
Hits 11244 11244
Misses 3116 3116
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice that we can now type to get to item and esc to close etc. however there are 2 small issues:
- The size of the dropdown does not have a min width AND/OR doesnt compute a min width from entries and so collapses to an unreadable narrow list when a short item is selected
- The snapshot compare list contains empty rows
…lity-selector-and-logs-dropdowns' into 4562_replace-assetCompare-visibility-selector-and-logs-dropdowns
…r-and-logs-dropdowns
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@cstns
Functionally, I am now happy with this.
Code wise also good however I am curious about the CSS. In particular, the affect or potential impact of using such common class names like "option", "options" and "button" in the controls. Prior to this work, they were much less likely to be impacted by any stray CSS classes as they were more verbose e.g ff-dropdown-options
.
Feel free to tell me this is nothing to worry about and proceed.
…r-and-logs-dropdowns
fix incoming, pending tests running locally |
…r-and-logs-dropdowns
Description
Replace the AssetCompareDialog, VisibilitySelector and Logs dropdowns
Related Issue(s)
close #4562
Checklist
flowforge.yml
?FlowFuse/helm
to update ConfigMap TemplateFlowFuse/CloudProject
to update values for Staging/ProductionLabels
area:migration
label