Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove image logo alt name to fix gmail email summary #4595

Merged
merged 1 commit into from
Sep 30, 2024

Conversation

cstns
Copy link
Contributor

@cstns cstns commented Sep 30, 2024

Description

removed logo img alt name so it won't appear in the summary on gmail

Related Issue(s)

closes #4593

Checklist

  • I have read the contribution guidelines
  • Suitable unit/system level tests have been added and they pass
  • Documentation has been updated
    • Upgrade instructions
    • Configuration details
    • Concepts
  • Changes flowforge.yml?
    • Issue/PR raised on FlowFuse/helm to update ConfigMap Template
    • Issue/PR raised on FlowFuse/CloudProject to update values for Staging/Production

Labels

  • Includes a DB migration? -> add the area:migration label

Copy link

codecov bot commented Sep 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.30%. Comparing base (d3e74b4) to head (3127ca7).
Report is 8 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4595   +/-   ##
=======================================
  Coverage   78.30%   78.30%           
=======================================
  Files         302      302           
  Lines       14360    14360           
  Branches     3265     3265           
=======================================
  Hits        11244    11244           
  Misses       3116     3116           
Flag Coverage Δ
backend 78.30% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cstns cstns self-assigned this Sep 30, 2024
@cstns cstns requested a review from Steve-Mcl September 30, 2024 12:59
@ZJvandeWeg ZJvandeWeg merged commit 3171bfb into main Sep 30, 2024
14 checks passed
@ZJvandeWeg ZJvandeWeg deleted the 4593_fix-emailing-template-alt branch September 30, 2024 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Emailing template contains what seems to be a css class
2 participants