Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Visual timeline of version history #4647

Merged
merged 54 commits into from
Oct 22, 2024
Merged

Visual timeline of version history #4647

merged 54 commits into from
Oct 22, 2024

Conversation

cstns
Copy link
Contributor

@cstns cstns commented Oct 15, 2024 •
edited
Loading

Description

Detached the snapshot page from the main instance page and nested it under a newly created VersionHistory page which will house both snapshots and the history timeline.

Related Issue(s)

closes #4304

Checklist

  • I have read the contribution guidelines
  • Suitable unit/system level tests have been added and they pass
  • Documentation has been updated
    • Upgrade instructions
    • Configuration details
    • Concepts
  • Changes flowforge.yml?
    • Issue/PR raised on FlowFuse/helm to update ConfigMap Template
    • Issue/PR raised on FlowFuse/CloudProject to update values for Staging/Production

Labels

  • Includes a DB migration? -> add the area:migration label

cstns added 4 commits October 15, 2024 16:08
@cstns
detach snapshots from the main instance panel and nest it under versi…
49f1446 
…on history
@cstns
fix failing e2e editor test
1cf9186
@cstns
fix missing component property, failing e2e test due to multiple crea…
4649fc3 
…te snapshot buttons present and snapshot list not updating due to the fact that the action buttons have been moved to it's parent component
@cstns
force instance update event to reload snapshot list after sucessfull …
ea20ca1 
…import
@cstns cstns self-assigned this Oct 15, 2024
@cstns cstns marked this pull request as draft October 15, 2024 14:45
@cstns
Copy link
Contributor Author

cstns commented Oct 15, 2024

This PR will serve as an initial step in the development of the history timeline. For the sake of namespacing and ease of review/release, the UI for the History Timeline will be handled in a separate PR which will point to this one.

@codecov Codecov
Copy link

codecov bot commented Oct 15, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.73%. Comparing base (607e2eb) to head (d9c1207).
Report is 55 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #4647   +/-   ##
=======================================
  Coverage   78.73%   78.73%           
=======================================
  Files         311      311           
  Lines       14665    14665           
  Branches     3352     3352           
=======================================
  Hits        11547    11547           
  Misses       3118     3118
Flag Coverage Δ
backend 78.73% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

cstns added 17 commits October 16, 2024 10:20
@cstns
add an api client for the timeline history endpoint
b1fc4a8
@cstns
adding timeline scaffolding
4e0b3a8
@cstns
adding timeline event boilerplate
f02b6ea
@cstns
adding timeline graph ui
5e1889e
@cstns
extract graph into separate component and add settings update event
a60d6d9
@cstns
add the ability to preview snapshots from history timeline and naviga…
8f7854e 
…te to deployed instances, xss prevention
@cstns
extract snapshot methods into a separate mixin to be used in the new …
f525c9f 
…timeline view
@cstns
use the snapshot response date as base for new date when exporting sn…
d0f2e22 
…apshots because the timeline snapshot doesn't have the updatedAt property
@cstns
add a kebab context menu for snapshot events
eaf1e56
@cstns
view toggle styling
4e489f8
@cstns
fix timeline/snapshot tab routing to work in the immersive editor as …
8779960 
…well
@cstns
add a timeline description
4829c5e
@cstns
patchwork fix for a quick in vue's router-link not recognizing the ac…
bcb1d15 
…tive route in the immersive view vs regular view
@cstns
cleanup
db0de6d
@cstns
adding timeline loading screen, transitions between snapshot/timeline…
3f0dc5f 
… panels and margin bottom to compensate for the hubspot chat
@cstns
trigger loading screen on snapshot rollback
b72f24f
@cstns
styling in order to make the timeline page fit entire space available
91bedca
@cstns cstns mentioned this pull request Oct 17, 2024
Merged
10 tasks
@cstns
Copy link
Contributor Author

cstns commented Oct 21, 2024

Please hold off on merging until the child pr is reviewed independently.
Both pr should be shipped as a whole

@cstns cstns marked this pull request as ready for review October 21, 2024 10:10
@cstns cstns requested review from Steve-Mcl and joepavitt October 21, 2024 10:10
cstns added 3 commits October 22, 2024 12:37
@cstns
Merge pull request #4650 from FlowFuse/visual-timeline-ui
376a38a 
Visual timeline UI
@cstns
Merge remote-tracking branch 'origin/main' into visual-timeline-of-ve…
59ddd87 
…rsion-history

# Conflicts:
#	frontend/src/pages/admin/TeamTypes/dialogs/TeamTypeEditDialog.vue
@cstns
merge fix
d9c1207
@cstns cstns merged commit 48a8c0f into main Oct 22, 2024
14 checks passed
@cstns cstns deleted the visual-timeline-of-version-history branch October 22, 2024 09:58
@cstns
Copy link
Contributor Author

cstns commented Oct 22, 2024

Created https://github.com/FlowFuse/CloudProject/issues/542 change request to enable the history timeline feature for team and enterprise team types on ff cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joepavitt joepavitt joepavitt approved these changes

@Steve-Mcl Steve-Mcl Awaiting requested review from Steve-Mcl

Assignees

@cstns cstns

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Visual Timeline of Version History
2 participants
@cstns @joepavitt