Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add repeat password field for confirmation #4670

Merged
merged 9 commits into from
Oct 22, 2024

Conversation

Steve-Mcl
Copy link
Contributor

closes #4616

Description

Adds repeat password field to sign up form

msedge_3W8Bmw5LPY

Related Issue(s)

#4616

Checklist

  • I have read the contribution guidelines
  • Suitable unit/system level tests have been added and they pass
  • Documentation has been updated
    • Upgrade instructions
    • Configuration details
    • Concepts
  • Changes flowforge.yml?
    • Issue/PR raised on FlowFuse/helm to update ConfigMap Template
    • Issue/PR raised on FlowFuse/CloudProject to update values for Staging/Production

Labels

  • Includes a DB migration? -> add the area:migration label

Copy link

codecov bot commented Oct 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.74%. Comparing base (2ac81cf) to head (5d740b0).
Report is 10 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4670   +/-   ##
=======================================
  Coverage   78.74%   78.74%           
=======================================
  Files         311      311           
  Lines       14667    14667           
  Branches     3353     3353           
=======================================
  Hits        11549    11549           
  Misses       3118     3118           
Flag Coverage Δ
backend 78.74% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@joepavitt
Copy link
Contributor

"Confirm Password" is generally the language used for this kind of I thing?

@joepavitt
Copy link
Contributor

@Steve-Mcl FYI the deploy blueprints function is failing, from memory, those tests have a sign up step to test the external "Deploy Blueprints" buttons, so I suspect it'll just be needing to have the "Confirm Password" field filled in too

@Steve-Mcl
Copy link
Contributor Author

"Confirm Password" is generally the language used for this kind of I thing?

GH uses repeat.
image

Amazon uses Re-enter Password
image

SO uses Confirm your Password
image

Surprisingly, most services DONT ask you to repeat/confirm password (only when changing it)

Either way, if you have a preference, let me know :)

@Steve-Mcl Steve-Mcl merged commit d61857b into main Oct 22, 2024
14 checks passed
@Steve-Mcl Steve-Mcl deleted the 4616-repeat-password-password branch October 22, 2024 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add "confirm password" to our sign up form
2 participants