Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure teamMembership in session for broker API #4674

Merged
merged 1 commit into from
Oct 22, 2024
Merged

Conversation

hardillb
Copy link
Contributor

Description

Make sure that the Team Broker API has access to Team Membership information.

Do need to look at adding Bearer Auth for API as well as Session Cookie based auth.

Related Issue(s)

#1350

Checklist

  • I have read the contribution guidelines
  • Suitable unit/system level tests have been added and they pass
  • Documentation has been updated
    • Upgrade instructions
    • Configuration details
    • Concepts
  • Changes flowforge.yml?
    • Issue/PR raised on FlowFuse/helm to update ConfigMap Template
    • Issue/PR raised on FlowFuse/CloudProject to update values for Staging/Production

Labels

  • Includes a DB migration? -> add the area:migration label

@hardillb hardillb requested a review from knolleary October 22, 2024 10:42
@hardillb hardillb self-assigned this Oct 22, 2024
Copy link

codecov bot commented Oct 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.74%. Comparing base (5a01c3b) to head (b2f72ac).
Report is 61 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4674   +/-   ##
=======================================
  Coverage   78.73%   78.74%           
=======================================
  Files         311      311           
  Lines       14665    14667    +2     
  Branches     3352     3353    +1     
=======================================
+ Hits        11547    11549    +2     
  Misses       3118     3118           
Flag Coverage Δ
backend 78.74% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@knolleary knolleary merged commit a63c3cb into main Oct 22, 2024
14 checks passed
@knolleary knolleary deleted the fix-api-auth-broker branch October 22, 2024 10:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants