Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Audit log shows empty username for password resets #4681

Merged
merged 1 commit into from
Oct 23, 2024
Merged

Conversation

hardillb
Copy link
Contributor

Description

While looking at a customer issue I noticed that if a user asks for a reset from the login page the audit log entry doesn't show anything useful as it only tries to display the username but only the email address is available.

Related Issue(s)

Checklist

  • I have read the contribution guidelines
  • Suitable unit/system level tests have been added and they pass
  • Documentation has been updated
    • Upgrade instructions
    • Configuration details
    • Concepts
  • Changes flowforge.yml?
    • Issue/PR raised on FlowFuse/helm to update ConfigMap Template
    • Issue/PR raised on FlowFuse/CloudProject to update values for Staging/Production

Labels

  • Includes a DB migration? -> add the area:migration label

While looking at a customer issue I noticed that if a user asks for a reset from the login page the audit log entry doesn't show anything useful as it only tries to display the username but only the email address is available.
@hardillb hardillb requested a review from knolleary October 23, 2024 08:29
@hardillb hardillb self-assigned this Oct 23, 2024
Copy link

codecov bot commented Oct 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.74%. Comparing base (84e863d) to head (f6e6971).
Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4681      +/-   ##
==========================================
- Coverage   78.74%   78.74%   -0.01%     
==========================================
  Files         311      311              
  Lines       14669    14667       -2     
  Branches     3354     3353       -1     
==========================================
- Hits        11551    11549       -2     
  Misses       3118     3118              
Flag Coverage Δ
backend 78.74% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hardillb hardillb merged commit 9f6fc28 into main Oct 23, 2024
14 checks passed
@hardillb hardillb deleted the hardillb-patch-2 branch October 23, 2024 08:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants