Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Put Team Broker behind a flag in the flowforge.yml #4688

Merged
merged 2 commits into from
Oct 24, 2024
Merged

Conversation

hardillb
Copy link
Contributor

Description

Put Team Broker behind a config flag

Related Issue(s)

Checklist

  • I have read the contribution guidelines
  • Suitable unit/system level tests have been added and they pass
  • Documentation has been updated
    • Upgrade instructions
    • Configuration details
    • Concepts
  • Changes flowforge.yml?
    • Issue/PR raised on FlowFuse/helm to update ConfigMap Template
    • Issue/PR raised on FlowFuse/CloudProject to update values for Staging/Production

Labels

  • Includes a DB migration? -> add the area:migration label

@hardillb hardillb requested a review from cstns October 24, 2024 08:54
@hardillb hardillb self-assigned this Oct 24, 2024
@cstns
Copy link
Contributor

cstns commented Oct 24, 2024

waiting for ui tests to run

Copy link

codecov bot commented Oct 24, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 78.73%. Comparing base (aea67e9) to head (af8ffdf).
Report is 5 commits behind head on main.

Files with missing lines Patch % Lines
forge/ee/lib/teamBroker/index.js 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4688      +/-   ##
==========================================
- Coverage   78.74%   78.73%   -0.01%     
==========================================
  Files         311      311              
  Lines       14669    14670       +1     
  Branches     3354     3355       +1     
==========================================
  Hits        11551    11551              
- Misses       3118     3119       +1     
Flag Coverage Δ
backend 78.73% <50.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cstns cstns merged commit 3a3d590 into main Oct 24, 2024
14 checks passed
@cstns cstns deleted the config-flag-team-broker branch October 24, 2024 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants