Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the missing tests for new broker Auth/ACL #4721

Merged
merged 5 commits into from
Nov 1, 2024
Merged

Conversation

hardillb
Copy link
Contributor

Description

Tests for project nodes and devices auth and acl checks

Basically a lift and shift of the V1 tests, just with the url changed and the acc to action change

Related Issue(s)

#1350

Checklist

  • I have read the contribution guidelines
  • Suitable unit/system level tests have been added and they pass
  • Documentation has been updated
    • Upgrade instructions
    • Configuration details
    • Concepts
  • Changes flowforge.yml?
    • Issue/PR raised on FlowFuse/helm to update ConfigMap Template
    • Issue/PR raised on FlowFuse/CloudProject to update values for Staging/Production

Labels

  • Includes a DB migration? -> add the area:migration label

@hardillb hardillb requested a review from Steve-Mcl October 31, 2024 16:45
@hardillb hardillb self-assigned this Oct 31, 2024
Copy link

codecov bot commented Oct 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.72%. Comparing base (35fd7a2) to head (f038bee).
Report is 10 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4721   +/-   ##
=======================================
  Coverage   78.72%   78.72%           
=======================================
  Files         311      311           
  Lines       14672    14672           
  Branches     3355     3355           
=======================================
  Hits        11551    11551           
  Misses       3121     3121           
Flag Coverage Δ
backend 78.72% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hardillb hardillb merged commit 53b25a8 into main Nov 1, 2024
14 checks passed
@hardillb hardillb deleted the broker-v2-acl-check branch November 1, 2024 11:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants