-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add "Event Scope" and "Include Children" to Instance Audit Logs #4753
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4753 +/- ##
==========================================
+ Coverage 78.65% 78.72% +0.07%
==========================================
Files 314 314
Lines 15050 15053 +3
Branches 3456 3457 +1
==========================================
+ Hits 11838 11851 +13
+ Misses 3212 3202 -10
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
Will hold off reviewing until the underling branch has a PR, as I'd like to take a look at that context/basis of this branch too. |
Ah, did go looking but didn't find it, thanks for clarifying Steve |
@joepavitt I've merged the changes from the base branch and applied the same edits to include the router-link in the audit log. I've updated this PRs 1st post to reflect. |
Approved, committed some minor amendments to pluralise the labels for "Scope", but not merging as waiting on #4749 |
closes #4750
closes #4751
Description
Adds "Event Scope" and "Include Children" to Instance Audit Logs
NOTE This merges into #4749. To keep #4749 manageable, we should probably not merge this in until that one is approved (but feel free to review and approve this up-front)
NOTE2 This also inadvertently fixes #4751
In action UPDATED to include associations as per discussion in #4749 comments
Tests added
Related Issue(s)
Owner: #4750
Parent: #4684
Checklist
flowforge.yml
?FlowFuse/helm
to update ConfigMap TemplateFlowFuse/CloudProject
to update values for Staging/ProductionLabels
area:migration
label