Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update 404 page #4757

Merged
merged 3 commits into from
Nov 12, 2024
Merged

Update 404 page #4757

merged 3 commits into from
Nov 12, 2024

Conversation

cstns
Copy link
Contributor

@cstns cstns commented Nov 11, 2024

Description

  • update the nearestContextualMenu handler to automatically match for any mainNavContext
  • renamed 404 routes to match kebab-case nomenclature
  • refactored team routes

Related Issue(s)

closes #3772

Checklist

  • I have read the contribution guidelines
  • Suitable unit/system level tests have been added and they pass
  • Documentation has been updated
    • Upgrade instructions
    • Configuration details
    • Concepts
  • Changes flowforge.yml?
    • Issue/PR raised on FlowFuse/helm to update ConfigMap Template
    • Issue/PR raised on FlowFuse/CloudProject to update values for Staging/Production

Labels

  • Includes a DB migration? -> add the area:migration label

- update the nearestContextualMenu handler to automatically match for any mainNavContext
- renamed 404 routes to match kebab-case nomenclature
@cstns cstns self-assigned this Nov 11, 2024
Copy link

codecov bot commented Nov 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.79%. Comparing base (ed3a4a1) to head (e660def).
Report is 4 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4757   +/-   ##
=======================================
  Coverage   78.79%   78.79%           
=======================================
  Files         311      311           
  Lines       14781    14781           
  Branches     3384     3384           
=======================================
  Hits        11646    11646           
  Misses       3135     3135           
Flag Coverage Δ
backend 78.79% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Base automatically changed from sidebar-redesign_left-drawer to main November 11, 2024 15:22
@joepavitt joepavitt merged commit 9e7b1e4 into main Nov 12, 2024
13 checks passed
@joepavitt joepavitt deleted the update-404-page branch November 12, 2024 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve our 404 Page
2 participants