-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add connection test button to LDAP SSO page #4787
Conversation
fixes #4782 Adds ability to test SSO LDAP credentials
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4787 +/- ##
==========================================
- Coverage 78.79% 78.61% -0.18%
==========================================
Files 311 311
Lines 14787 14822 +35
Branches 3387 3396 +9
==========================================
+ Hits 11651 11653 +2
- Misses 3136 3169 +33
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
Not sure how to test this without mocking a LDAP server. The old |
Agreed we aren't well setup for testing ldap in CI; lets not spend time on that right now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Having approved initially, spotted the error reporting was mismatched in one scenario in terms of the property used to store the message. Have proposed changes to align them all. Also made the test button smaller.
Co-authored-by: Nick O'Leary <nick.oleary@gmail.com>
Co-authored-by: Nick O'Leary <nick.oleary@gmail.com>
Co-authored-by: Nick O'Leary <nick.oleary@gmail.com>
fixes #4782
Description
Adds ability to test SSO LDAP credentials
This adds 1 new API endpoint and a minor change to the LDAP SSO config page to add test button.
/ee/sso/providers/test
takes the same payload as the update provider, and needs same permissionsReturns 200 and empty json for success or 400 and standard error json for failure, with messages to suite the type of failure.
feedback is via Alerts, success
or for failure
Note, button is secondary, only showing blue here because mouse is over it in the screenshot
Related Issue(s)
Checklist
flowforge.yml
?FlowFuse/helm
to update ConfigMap TemplateFlowFuse/CloudProject
to update values for Staging/ProductionLabels
area:migration
label