Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix device groups layout #4817

Merged
merged 2 commits into from
Nov 22, 2024
Merged

fix device groups layout #4817

merged 2 commits into from
Nov 22, 2024

Conversation

Steve-Mcl
Copy link
Contributor

closes #4712

Description

  • fix tab highlight being lost
  • fix layout by utilising the SectionTopMenu like other pages in the app do

Related Issue(s)

#4712

Checklist

  • I have read the contribution guidelines
  • Suitable unit/system level tests have been added and they pass
  • Documentation has been updated
    • Upgrade instructions
    • Configuration details
    • Concepts
  • Changes flowforge.yml?
    • Issue/PR raised on FlowFuse/helm to update ConfigMap Template
    • Issue/PR raised on FlowFuse/CloudProject to update values for Staging/Production

Labels

  • Includes a DB migration? -> add the area:migration label

Copy link
Contributor

@cstns cstns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good!

Copy link

codecov bot commented Nov 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.73%. Comparing base (eee84bc) to head (2d74e7a).
Report is 11 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4817   +/-   ##
=======================================
  Coverage   78.73%   78.73%           
=======================================
  Files         314      314           
  Lines       15063    15063           
  Branches     3461     3461           
=======================================
  Hits        11860    11860           
  Misses       3203     3203           
Flag Coverage Δ
backend 78.73% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@Steve-Mcl Steve-Mcl merged commit ffa0555 into main Nov 22, 2024
13 checks passed
@Steve-Mcl Steve-Mcl deleted the 4712-fix-devicegroup-layout branch November 22, 2024 11:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Device Group Settings page UI issue
2 participants