Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow branding settings to be cleared in the UI #4841

Merged
merged 1 commit into from
Nov 28, 2024

Conversation

knolleary
Copy link
Member

Fixes #4831

The two branding settings branding:account:signUpTopBanner and branding:account:signUpLeftBanner can, for historic reasons, be set via the .yml or the admin UI.

If set in the yml, it can be overridden by the admin UI. However, if the admin UI sets it to a blank string, the value of yml is used again; there's no way for admin to override it to a blank string... until now.

Rather than just check the truthiness of these two settings, it now checks if they are not null (the default value).

@knolleary knolleary requested a review from hardillb November 28, 2024 10:38
Copy link

codecov bot commented Nov 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.67%. Comparing base (4ab0fb2) to head (41ab061).
Report is 9 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4841   +/-   ##
=======================================
  Coverage   78.67%   78.67%           
=======================================
  Files         314      314           
  Lines       15125    15125           
  Branches     3483     3483           
=======================================
  Hits        11900    11900           
  Misses       3225     3225           
Flag Coverage Δ
backend 78.67% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hardillb hardillb merged commit 2450e46 into main Nov 28, 2024
13 checks passed
@hardillb hardillb deleted the 4831-clear-admin-field branch November 28, 2024 10:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to clear 'HTML to show above sign-up form' field
2 participants