Allow branding settings to be cleared in the UI #4841
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4831
The two branding settings
branding:account:signUpTopBanner
andbranding:account:signUpLeftBanner
can, for historic reasons, be set via the.yml
or the admin UI.If set in the
yml
, it can be overridden by the admin UI. However, if the admin UI sets it to a blank string, the value of yml is used again; there's no way for admin to override it to a blank string... until now.Rather than just check the truthiness of these two settings, it now checks if they are not null (the default value).