Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more filters for admin notification targeting #4843

Merged
merged 6 commits into from
Dec 4, 2024

Conversation

knolleary
Copy link
Member

Description

Allows notification hub messages to be targeted to users of certain team types and billing states.

image

@knolleary knolleary requested review from cstns and removed request for cstns November 28, 2024 15:12
Copy link

codecov bot commented Nov 28, 2024

Codecov Report

Attention: Patch coverage is 75.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 78.71%. Comparing base (16ec27d) to head (c4bd0c9).
Report is 77 commits behind head on main.

Files with missing lines Patch % Lines
forge/db/models/User.js 66.66% 2 Missing ⚠️
forge/routes/api/admin.js 83.33% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4843      +/-   ##
==========================================
+ Coverage   78.67%   78.71%   +0.03%     
==========================================
  Files         314      317       +3     
  Lines       15125    15178      +53     
  Branches     3483     3491       +8     
==========================================
+ Hits        11900    11947      +47     
- Misses       3225     3231       +6     
Flag Coverage Δ
backend 78.71% <75.00%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

forge/routes/api/admin.js Outdated Show resolved Hide resolved
frontend/src/pages/admin/NotificationsHub.vue Outdated Show resolved Hide resolved
knolleary and others added 3 commits December 3, 2024 16:48
Co-authored-by: Costin Serban <cstn.serban@gmail.com>
Co-authored-by: Costin Serban <cstn.serban@gmail.com>
@knolleary
Copy link
Member Author

Fixes applied - all working locally.

@knolleary knolleary requested a review from cstns December 3, 2024 16:57
Copy link
Contributor

@cstns cstns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good to me!

@knolleary knolleary linked an issue Dec 3, 2024 that may be closed by this pull request
@cstns cstns merged commit f77d1d9 into main Dec 4, 2024
13 checks passed
@cstns cstns deleted the 4830-admin-notification-filters branch December 4, 2024 08:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add notification filter for team type and subscription status
2 participants