Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Team member device mode toggle #4844

Merged
merged 5 commits into from
Nov 29, 2024
Merged

Conversation

hardillb
Copy link
Contributor

@hardillb hardillb commented Nov 28, 2024

part of #4778

Description

adds device.memberEnableDeviceDeveloperMode to flowfuse.yml, defaults to false

if set to true allows a Team Member to toggle developer mode on/off

Updates permissions so that Member role can toggle developer mode on a device - as this is a common task.

Related Issue(s)

#4778

Checklist

  • I have read the contribution guidelines
  • Suitable unit/system level tests have been added and they pass
  • Documentation has been updated
    • Upgrade instructions
    • Configuration details
    • Concepts
  • Changes flowforge.yml?
    • Issue/PR raised on FlowFuse/helm to update ConfigMap Template
    • Issue/PR raised on FlowFuse/CloudProject to update values for Staging/Production

Labels

  • Includes a DB migration? -> add the area:migration label

part of #4778

Adds `device.memberEnableDeviceDeveloperMode` to configuration
options. Defaults to `false`, but if set to `true` a Team
Member as well as Team Owner can change the devices status
@hardillb hardillb self-assigned this Nov 28, 2024
@hardillb
Copy link
Contributor Author

Letting UI tests run to see if they need updating

Copy link

codecov bot commented Nov 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.67%. Comparing base (511acde) to head (6e1d7b8).
Report is 6 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4844   +/-   ##
=======================================
  Coverage   78.67%   78.67%           
=======================================
  Files         314      314           
  Lines       15125    15125           
  Branches     3483     3483           
=======================================
  Hits        11900    11900           
  Misses       3225     3225           
Flag Coverage Δ
backend 78.67% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hardillb hardillb marked this pull request as ready for review November 28, 2024 16:17
@knolleary knolleary merged commit 645a2c7 into main Nov 29, 2024
13 checks passed
@knolleary knolleary deleted the team-member-device-mode-toggle branch November 29, 2024 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants