Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Team Pipelines API #4847

Merged
merged 4 commits into from
Dec 2, 2024
Merged

Team Pipelines API #4847

merged 4 commits into from
Dec 2, 2024

Conversation

hardillb
Copy link
Contributor

@hardillb hardillb commented Nov 29, 2024

part of #4822

Description

Adds API endpoint

  • GET /api/v1/teams/:teamid/pipelines returns PipelineList with extra application.id and application.name

Related Issue(s)

#4822

Checklist

  • I have read the contribution guidelines
  • Suitable unit/system level tests have been added and they pass
  • Documentation has been updated
    • Upgrade instructions
    • Configuration details
    • Concepts
  • Changes flowforge.yml?
    • Issue/PR raised on FlowFuse/helm to update ConfigMap Template
    • Issue/PR raised on FlowFuse/CloudProject to update values for Staging/Production

Labels

  • Includes a DB migration? -> add the area:migration label

part of #4822

Adds API endpoint

- GET `/api/v1/teams/:teamid/pipelines` returns PipelineList
  with extra `application.id` and `application.name`
@hardillb hardillb requested a review from cstns November 29, 2024 15:27
@hardillb hardillb self-assigned this Nov 29, 2024
@hardillb
Copy link
Contributor Author

Needs tests

Copy link

codecov bot commented Nov 29, 2024

Codecov Report

Attention: Patch coverage is 90.90909% with 2 lines in your changes missing coverage. Please review.

Project coverage is 78.69%. Comparing base (511acde) to head (5f9bc01).
Report is 17 commits behind head on main.

Files with missing lines Patch % Lines
forge/ee/db/views/Pipeline.js 90.00% 1 Missing ⚠️
forge/ee/routes/pipeline/teamPipelines.js 85.71% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4847      +/-   ##
==========================================
+ Coverage   78.67%   78.69%   +0.01%     
==========================================
  Files         314      315       +1     
  Lines       15125    15147      +22     
  Branches     3483     3486       +3     
==========================================
+ Hits        11900    11920      +20     
- Misses       3225     3227       +2     
Flag Coverage Δ
backend 78.69% <90.90%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@joepavitt
Copy link
Contributor

Any reason not merged?

@cstns
Copy link
Contributor

cstns commented Dec 2, 2024

Any reason not merged?

no, merging as i write

@cstns cstns merged commit fa4f8c4 into main Dec 2, 2024
13 checks passed
@cstns cstns deleted the team-pipeline-api branch December 2, 2024 12:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants