Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Publish to npm only on successful tests #4848

Merged
merged 4 commits into from
Nov 30, 2024

Conversation

ppawlowski
Copy link
Contributor

@ppawlowski ppawlowski commented Nov 30, 2024

Description

This pull request introduces the Check tests statuses job to the Publish workflow.

The purpose of this job is to ensure that the flowfuse package is published to the NPM registry only if at least one test job from the Tests workflow completes successfully. If all test jobs, as specified in the jobsToCheck array, are skipped, the package will not be published.
Moreover, the script verifies whether any of the test jobs failed. However, this scenario should not occur due to the github.event.workflow_run.conclusion == 'success' conditional statement, which ensures that the Tests workflow must have concluded successfully before reaching this point.

Related Issue(s)

Closes #4708

Checklist

  • I have read the contribution guidelines
  • Suitable unit/system level tests have been added and they pass
  • Documentation has been updated
    • Upgrade instructions
    • Configuration details
    • Concepts
  • Changes flowforge.yml?
    • Issue/PR raised on FlowFuse/helm to update ConfigMap Template
    • Issue/PR raised on FlowFuse/CloudProject to update values for Staging/Production

Labels

  • Includes a DB migration? -> add the area:migration label

@ppawlowski ppawlowski marked this pull request as ready for review November 30, 2024 19:47
@ppawlowski ppawlowski requested a review from hardillb November 30, 2024 19:47
@hardillb hardillb merged commit 70451b1 into main Nov 30, 2024
9 checks passed
@hardillb hardillb deleted the ci-publish-pipeline-trigger-fix branch November 30, 2024 22:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ci: NPM publish package workflow should not be triggered if no tests are executed
2 participants