Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expand the UNS Hierarchy by default & improve hover behaviour #4854

Merged
merged 3 commits into from
Dec 3, 2024

Conversation

joepavitt
Copy link
Contributor

@joepavitt joepavitt commented Dec 2, 2024

Description

It's annoying to have to expand many layers each time, and given that it's a single single to minimise a whole branch of the hierarchy, expanded by default makes more sense.

The default "closed" view also implies there is nothing on the screen, especially if the first nested topic is /

Screenshot 2024-12-02 at 21 10 07

Also improves the hover state, with a pointer:cursor and highlighted text:

Screenshot 2024-12-02 at 21 11 35

Copy link

codecov bot commented Dec 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.69%. Comparing base (7eebf0f) to head (e0633b9).
Report is 11 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4854   +/-   ##
=======================================
  Coverage   78.69%   78.69%           
=======================================
  Files         315      315           
  Lines       15147    15147           
  Branches     3486     3486           
=======================================
  Hits        11920    11920           
  Misses       3227     3227           
Flag Coverage Δ
backend 78.69% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cstns
Copy link
Contributor

cstns commented Dec 3, 2024

The fact that the ff-accordion component was rendering the html elements was the main reason i ended up not using it for rendering the nested hierarchy. For small payloads with <50 topics it behaves nicely but when you exceed that, the initial page render and DOM draw over cumbers the page and might freeze it.

By programmatically hiding the elements and only drawing the starting segments I managed to load 1500 entries with >50 nested topics.

I'd go with a variant of opening only the first n topics up to an m level

@joepavitt
Copy link
Contributor Author

joepavitt commented Dec 3, 2024

I'd go with a variant of opening only the first n topics up to an m level

That's a fair counter proposal - could I ask you to jump in and cover/extend this PR please? I need to sort other bits before my demo at 12

Copy link
Contributor

@cstns cstns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

accepting changes due to the current low number of broker users and topics.

A cohesive implementation will be done in #4857

@cstns cstns merged commit 12e82ee into main Dec 3, 2024
13 checks passed
@cstns cstns deleted the uns-hiearchy-expanded branch December 3, 2024 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants