Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure existing http auth tokens shown #4861

Merged
merged 1 commit into from
Dec 3, 2024
Merged

Conversation

hardillb
Copy link
Contributor

@hardillb hardillb commented Dec 3, 2024

fixes #4860

Description

If there existing Instance HTTP Auth tokens, but FlowFuse auth is not enabled, when enabling the tokens were not shown.

Related Issue(s)

#4860

Checklist

  • I have read the contribution guidelines
  • Suitable unit/system level tests have been added and they pass
  • Documentation has been updated
    • Upgrade instructions
    • Configuration details
    • Concepts
  • Changes flowforge.yml?
    • Issue/PR raised on FlowFuse/helm to update ConfigMap Template
    • Issue/PR raised on FlowFuse/CloudProject to update values for Staging/Production

Labels

  • Includes a DB migration? -> add the area:migration label

@hardillb hardillb requested a review from cstns December 3, 2024 12:12
@hardillb hardillb self-assigned this Dec 3, 2024
Copy link

codecov bot commented Dec 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.70%. Comparing base (12e82ee) to head (02b8856).
Report is 4 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4861   +/-   ##
=======================================
  Coverage   78.70%   78.70%           
=======================================
  Files         316      316           
  Lines       15152    15152           
  Branches     3486     3486           
=======================================
  Hits        11925    11925           
  Misses       3227     3227           
Flag Coverage Δ
backend 78.70% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cstns cstns merged commit 5ee7616 into main Dec 3, 2024
13 checks passed
@cstns cstns deleted the fix-existing-http-tokens branch December 3, 2024 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Exisitng FlowFuse HTTP Authentication Tokens now shown
2 participants