-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Team Bill Of Materials UI #4872
Conversation
…t common bom methods in a mixin
…cies view + styling
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4872 +/- ##
==========================================
- Coverage 78.74% 78.69% -0.06%
==========================================
Files 323 323
Lines 15221 15242 +21
Branches 3496 3504 +8
==========================================
+ Hits 11986 11994 +8
- Misses 3235 3248 +13
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Based on our chat this morning, I wasn't expecting this ready so soon - just checking it's actually ready for review, before I dive in? |
Not yet! I did not start to change the ff-accordion. Will mark the pr as draft until i address it. For visibility, I have reservations of using the existing layout as is because the ff-accordion does not programmatically hide it's contents which means they would get rendered in the dom each time even though not visible. This would have negative impact on big payloads and could cause the page to freeze |
@cstns ready for review? |
Yes! |
Description
Related Issue(s)
closes #4823
Checklist
flowforge.yml
?FlowFuse/helm
to update ConfigMap TemplateFlowFuse/CloudProject
to update values for Staging/ProductionLabels
area:migration
label