Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Team Bill Of Materials UI #4872

Merged
merged 31 commits into from
Dec 13, 2024
Merged

Team Bill Of Materials UI #4872

merged 31 commits into from
Dec 13, 2024

Conversation

cstns
Copy link
Contributor

@cstns cstns commented Dec 4, 2024

Description

  • updated the api to include device/instance status
  • centralized application bom components and reused them in both team and app bom
  • styling
  • altered the ff accordion to programmatically hide it's content instead of altering it's display property
  • truncate versions instances and add a show more button
  • add a version counter to each dependency
  • toggle dependency package versions
  • make the dependency items start in a closed state on the team bom

Related Issue(s)

closes #4823

Checklist

  • I have read the contribution guidelines
  • Suitable unit/system level tests have been added and they pass
  • Documentation has been updated
    • Upgrade instructions
    • Configuration details
    • Concepts
  • Changes flowforge.yml?
    • Issue/PR raised on FlowFuse/helm to update ConfigMap Template
    • Issue/PR raised on FlowFuse/CloudProject to update values for Staging/Production

Labels

  • Includes a DB migration? -> add the area:migration label

@cstns cstns self-assigned this Dec 4, 2024
Copy link

codecov bot commented Dec 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.69%. Comparing base (b545283) to head (66d50a0).
Report is 76 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4872      +/-   ##
==========================================
- Coverage   78.74%   78.69%   -0.06%     
==========================================
  Files         323      323              
  Lines       15221    15242      +21     
  Branches     3496     3504       +8     
==========================================
+ Hits        11986    11994       +8     
- Misses       3235     3248      +13     
Flag Coverage Δ
backend 78.69% <100.00%> (-0.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cstns cstns requested a review from joepavitt December 5, 2024 10:38
@joepavitt
Copy link
Contributor

Based on our chat this morning, I wasn't expecting this ready so soon - just checking it's actually ready for review, before I dive in?

@cstns
Copy link
Contributor Author

cstns commented Dec 6, 2024

Not yet! I did not start to change the ff-accordion. Will mark the pr as draft until i address it.

For visibility, I have reservations of using the existing layout as is because the ff-accordion does not programmatically hide it's contents which means they would get rendered in the dom each time even though not visible. This would have negative impact on big payloads and could cause the page to freeze

@cstns cstns marked this pull request as draft December 6, 2024 13:39
@cstns cstns marked this pull request as ready for review December 9, 2024 14:19
@joepavitt
Copy link
Contributor

@cstns ready for review?

@cstns
Copy link
Contributor Author

cstns commented Dec 13, 2024

Yes!

@joepavitt
Copy link
Contributor

Screenshot 2024-12-13 at 13 53 59

Added sorting for the version numbers within the first accordian

frontend/src/components/Accordion.vue Outdated Show resolved Hide resolved
frontend/src/mixins/BOM.js Outdated Show resolved Hide resolved
@joepavitt joepavitt merged commit 4884866 into main Dec 13, 2024
17 of 18 checks passed
@joepavitt joepavitt deleted the team-bom-ui branch December 13, 2024 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Team View: Bill of Materials
2 participants