Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow NR Dashboard to be loaded in iFrames #4900

Merged
merged 1 commit into from
Dec 19, 2024
Merged

Allow NR Dashboard to be loaded in iFrames #4900

merged 1 commit into from
Dec 19, 2024

Conversation

hardillb
Copy link
Contributor

@hardillb hardillb commented Dec 10, 2024

part of #4689

Description

Allows owner to configure if Dashboards should be embeddable in an iFrame.

First pass allows dashboard to be loaded from anywhere

Has a feature test for nr-launcher of greater than 2.12.0

paired with FlowFuse/nr-launcher#306

Related Issue(s)

#4689

Checklist

  • I have read the contribution guidelines
  • Suitable unit/system level tests have been added and they pass
  • Documentation has been updated
    • Upgrade instructions
    • Configuration details
    • Concepts
  • Changes flowforge.yml?
    • Issue/PR raised on FlowFuse/helm to update ConfigMap Template
    • Issue/PR raised on FlowFuse/CloudProject to update values for Staging/Production

Labels

  • Includes a DB migration? -> add the area:migration label

Copy link

codecov bot commented Dec 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.74%. Comparing base (7a98b70) to head (e5ccd41).
Report is 190 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4900   +/-   ##
=======================================
  Coverage   78.74%   78.74%           
=======================================
  Files         323      323           
  Lines       15221    15221           
  Branches     3496     3496           
=======================================
  Hits        11986    11986           
  Misses       3235     3235           
Flag Coverage Δ
backend 78.74% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hardillb
Copy link
Contributor Author

Tested with both DBv1 and DBv2

@hardillb
Copy link
Contributor Author

Ready for review, but should not be merged until the nr-launcher pr is merged and published (so part of 2.12.0 release)

@hardillb hardillb marked this pull request as ready for review December 11, 2024 09:22
Copy link
Contributor

@Steve-Mcl Steve-Mcl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Not merging as per request

@hardillb
Copy link
Contributor Author

@Steve-Mcl thanks, I've tagged you on the nr-launcher side as well for completeness

@knolleary knolleary removed their request for review December 13, 2024 10:16
@hardillb hardillb merged commit e26f0ee into main Dec 19, 2024
20 checks passed
@hardillb hardillb deleted the dashboard-iframe branch December 19, 2024 10:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants