-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow for prefix/suffix to SSO GroupNames #4902
Conversation
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4902 +/- ##
==========================================
- Coverage 78.74% 78.69% -0.06%
==========================================
Files 323 323
Lines 15221 15242 +21
Branches 3496 3504 +8
==========================================
+ Hits 11986 11994 +8
- Misses 3235 3248 +13
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Tests for SAML pattern, the LDAP function needs a functional LDAP server to run against. I did test both against my local KeyCloak and LDAP system |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved, but some doc/text/updates to apply first.
Co-authored-by: Nick O'Leary <nick.oleary@gmail.com>
Co-authored-by: Nick O'Leary <nick.oleary@gmail.com>
fixes #4768
Description
Allows a prefix and suffix length to be defined for SSO group names, this works for both SAML and LDAP.
e.g.
ff requires groupnames in the following format
ff-teamslug-role
, this allows an arbitrary number of characters to be before and after this format. e.g.with prefix and suffix length set to 5 the following group would match
test_ff-teamslug-role_test
Related Issue(s)
#4768
Checklist
flowforge.yml
?FlowFuse/helm
to update ConfigMap TemplateFlowFuse/CloudProject
to update values for Staging/ProductionLabels
area:migration
label