Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return device type in application/devices #4904

Merged
merged 4 commits into from
Dec 12, 2024
Merged

Conversation

hardillb
Copy link
Contributor

@hardillb hardillb commented Dec 11, 2024

part of #4176

Description

This is just the API change

n.b.
included the device type in the application search as well

Related Issue(s)

closes #4176

Checklist

  • I have read the contribution guidelines
  • Suitable unit/system level tests have been added and they pass
  • Documentation has been updated
    • Upgrade instructions
    • Configuration details
    • Concepts
  • Changes flowforge.yml?
    • Issue/PR raised on FlowFuse/helm to update ConfigMap Template
    • Issue/PR raised on FlowFuse/CloudProject to update values for Staging/Production

Labels

  • Includes a DB migration? -> add the area:migration label

part of #4176

This is just the API change
@hardillb hardillb requested a review from cstns December 11, 2024 17:14
@hardillb hardillb self-assigned this Dec 11, 2024
Copy link

codecov bot commented Dec 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.70%. Comparing base (0445a24) to head (0cda7a4).
Report is 5 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4904   +/-   ##
=======================================
  Coverage   78.70%   78.70%           
=======================================
  Files         323      323           
  Lines       15230    15230           
  Branches     3498     3498           
=======================================
  Hits        11987    11987           
  Misses       3243     3243           
Flag Coverage Δ
backend 78.70% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cstns
Copy link
Contributor

cstns commented Dec 12, 2024

spot on!
I took the liberty and added the device type in the application search to save ourselves another pr!

@cstns cstns merged commit 1f241e3 into main Dec 12, 2024
18 checks passed
@cstns cstns deleted the add-type-application-devices branch December 12, 2024 11:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add device type to the application devices response and include it in the search action
2 participants