Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure Device Provisioning tokens removed with Team #4906

Merged
merged 2 commits into from
Dec 13, 2024

Conversation

hardillb
Copy link
Contributor

Description

This removes Team Device Provisioning tokens when team is deleted

Related Issue(s)

Checklist

  • I have read the contribution guidelines
  • Suitable unit/system level tests have been added and they pass
  • Documentation has been updated
    • Upgrade instructions
    • Configuration details
    • Concepts
  • Changes flowforge.yml?
    • Issue/PR raised on FlowFuse/helm to update ConfigMap Template
    • Issue/PR raised on FlowFuse/CloudProject to update values for Staging/Production

Labels

  • Includes a DB migration? -> add the area:migration label

This removes Team Device Provisioning tokens when team is deleted
Copy link

codecov bot commented Dec 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.70%. Comparing base (1f241e3) to head (39fec43).
Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4906   +/-   ##
=======================================
  Coverage   78.70%   78.70%           
=======================================
  Files         323      323           
  Lines       15230    15231    +1     
  Branches     3498     3498           
=======================================
+ Hits        11987    11988    +1     
  Misses       3243     3243           
Flag Coverage Δ
backend 78.70% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hardillb
Copy link
Contributor Author

There was an intermittent UI tests failure after I fixed forcing the team id to be a string.

@knolleary knolleary merged commit d325765 into main Dec 13, 2024
18 checks passed
@knolleary knolleary deleted the remove-dev-prov-tokens branch December 13, 2024 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants