Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add logo version for dark backgrounds #4930

Merged
merged 3 commits into from
Dec 17, 2024
Merged

Add logo version for dark backgrounds #4930

merged 3 commits into from
Dec 17, 2024

Conversation

Yndira-E
Copy link
Contributor

Description

On https://github.com/FlowFuse/flowfuse/pull/4924/files the logo was deleted, and now there's no logo in the top bar.
Screenshot 2024-12-17 at 13 19 11

I’ve just added the latest version and performed a ‘find/replace’ search for the name of the old file.

Related Issue(s)

Checklist

  • I have read the contribution guidelines
  • Suitable unit/system level tests have been added and they pass
  • Documentation has been updated
    • Upgrade instructions
    • Configuration details
    • Concepts
  • Changes flowforge.yml?
    • Issue/PR raised on FlowFuse/helm to update ConfigMap Template
    • Issue/PR raised on FlowFuse/CloudProject to update values for Staging/Production

Labels

  • Includes a DB migration? -> add the area:migration label

Copy link

codecov bot commented Dec 17, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 78.63%. Comparing base (be3af14) to head (8e22980).
Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
forge/routes/api-docs.js 50.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4930   +/-   ##
=======================================
  Coverage   78.63%   78.63%           
=======================================
  Files         324      324           
  Lines       15265    15265           
  Branches     3507     3507           
=======================================
  Hits        12003    12003           
  Misses       3262     3262           
Flag Coverage Δ
backend 78.63% <50.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@cstns cstns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch @Yndira-E, This should have been caught locally but the clean webpack plugin served us a nasty error

@cstns cstns merged commit 181b34e into main Dec 17, 2024
16 checks passed
@cstns cstns deleted the add-dark-bg-logo-version branch December 17, 2024 12:58
@cstns
Copy link
Contributor

cstns commented Dec 17, 2024

linking here #4931

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants