Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decrease device auto timeout to 15 seconds from 30 #4932

Merged
merged 1 commit into from
Dec 17, 2024

Conversation

hardillb
Copy link
Contributor

part of #4832

Description

reduces the time the device agent will continue to send logs in the background if a single user navigates away from the logs page. This should make for a better experience of returning to the page and seeing log history.

Related Issue(s)

Checklist

  • I have read the contribution guidelines
  • Suitable unit/system level tests have been added and they pass
  • Documentation has been updated
    • Upgrade instructions
    • Configuration details
    • Concepts
  • Changes flowforge.yml?
    • Issue/PR raised on FlowFuse/helm to update ConfigMap Template
    • Issue/PR raised on FlowFuse/CloudProject to update values for Staging/Production

Labels

  • Includes a DB migration? -> add the area:migration label

Copy link

codecov bot commented Dec 17, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 78.64%. Comparing base (bdf5dae) to head (d6cd220).
Report is 12 commits behind head on main.

Files with missing lines Patch % Lines
forge/comms/devices.js 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4932      +/-   ##
==========================================
+ Coverage   78.63%   78.64%   +0.01%     
==========================================
  Files         324      324              
  Lines       15265    15265              
  Branches     3507     3507              
==========================================
+ Hits        12003    12005       +2     
+ Misses       3262     3260       -2     
Flag Coverage Δ
backend 78.64% <0.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@knolleary knolleary merged commit 775c19f into main Dec 17, 2024
18 checks passed
@knolleary knolleary deleted the reduce-device-log-timeout branch December 17, 2024 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants