Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add system-ui as a backup font for heebo (to match internal font) #4946

Merged
merged 2 commits into from
Dec 19, 2024

Conversation

cstns
Copy link
Contributor

@cstns cstns commented Dec 19, 2024

Description

Related Issue(s)

closes #4944

Checklist

  • I have read the contribution guidelines
  • Suitable unit/system level tests have been added and they pass
  • Documentation has been updated
    • Upgrade instructions
    • Configuration details
    • Concepts
  • Changes flowforge.yml?
    • Issue/PR raised on FlowFuse/helm to update ConfigMap Template
    • Issue/PR raised on FlowFuse/CloudProject to update values for Staging/Production

Labels

  • Includes a DB migration? -> add the area:migration label

Copy link

codecov bot commented Dec 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.59%. Comparing base (3a30552) to head (f56aeea).
Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4946   +/-   ##
=======================================
  Coverage   78.59%   78.59%           
=======================================
  Files         325      325           
  Lines       15296    15296           
  Branches     3512     3512           
=======================================
  Hits        12022    12022           
  Misses       3274     3274           
Flag Coverage Δ
backend 78.59% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Co-authored-by: Stephen McLaughlin <44235289+Steve-Mcl@users.noreply.github.com>
@Steve-Mcl Steve-Mcl self-requested a review December 19, 2024 10:13
Copy link
Contributor

@Steve-Mcl Steve-Mcl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, awaiting tests passing

@Steve-Mcl Steve-Mcl merged commit 17b0467 into main Dec 19, 2024
17 checks passed
@Steve-Mcl Steve-Mcl deleted the add-heebo-backup-font branch December 19, 2024 10:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Login page text using windows default serif font on windows+chrome
2 participants