Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Alter UITemplate dataTracker bind to anonymous component #1097

Merged
merged 2 commits into from
Jul 30, 2024
Merged

Alter UITemplate dataTracker bind to anonymous component #1097

merged 2 commits into from
Jul 30, 2024

Conversation

cstns
Copy link
Contributor

@cstns cstns commented Jul 15, 2024

Description

bind the dataTracker with the mounted component instead of the parent to preserve reactivity after socket disconnect/reconnect

Related Issue(s)

closes #747

Checklist

  • I have read the contribution guidelines
  • Suitable unit/system level tests have been added and they pass
  • Documentation has been updated
    • Upgrade instructions
    • Configuration details
    • Concepts
  • Changes flowforge.yml?
    • Issue/PR raised on FlowFuse/helm to update ConfigMap Template
    • Issue/PR raised on FlowFuse/CloudProject to update values for Staging/Production

Labels

  • Includes a DB migration? -> add the area:migration label

@cstns cstns requested a review from joepavitt July 15, 2024 13:11
@cstns cstns self-assigned this Jul 15, 2024
@cstns
Copy link
Contributor Author

cstns commented Jul 15, 2024

failing tests do not seem to be related to current fix

@cstns cstns mentioned this pull request Jul 16, 2024
Merged
10 tasks
@cstns
Copy link
Contributor Author

cstns commented Jul 16, 2024

Should be merged after #1099.

before accepting, check changes from #1099 and this fix/replace the usage of useDataTracker composable with this.$useDataTracker injected value instead

@joepavitt joepavitt mentioned this pull request Jul 28, 2024
Closed
@joepavitt joepavitt force-pushed the 747_ui-template-nodes-not-receiving-messages-after-network-disconnection-recovery branch from 227da1f to 37b8656 Compare July 30, 2024 08:52
@joepavitt joepavitt merged commit 925616b into main Jul 30, 2024
1 of 2 checks passed
@joepavitt joepavitt deleted the 747_ui-template-nodes-not-receiving-messages-after-network-disconnection-recovery branch July 30, 2024 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joepavitt joepavitt joepavitt approved these changes

Assignees

@cstns cstns

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ui-template nodes not receiving messages after network disconnection/recovery.
2 participants
@cstns @joepavitt