Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UI Switch - Handle memory share bug from datastore & ensure msg sent #1184

Merged
merged 2 commits into from
Aug 8, 2024
Merged

UI Switch - Handle memory share bug from datastore & ensure msg sent #1184

merged 2 commits into from
Aug 8, 2024

Conversation

joepavitt
Copy link
Collaborator

Description

  • Ensures we aren't overriding datastore contents due to shared memory pointers
  • Adds E2E Tests to prevent regression again
  • Ensure we send message when clicked, even if decoupled

Related Issue(s)

Closes #1174 (again)

@joepavitt joepavitt requested a review from Steve-Mcl August 8, 2024 15:47
@Steve-Mcl Steve-Mcl merged commit 3adf3fb into main Aug 8, 2024
1 of 2 checks passed
@Steve-Mcl Steve-Mcl deleted the 1174-memry-bug branch August 8, 2024 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Steve-Mcl Steve-Mcl Steve-Mcl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@joepavitt @Steve-Mcl