Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Defaults set before Vuetify loading #1185

Merged
merged 2 commits into from
Aug 9, 2024
Merged

Conversation

joepavitt
Copy link
Collaborator

@joepavitt joepavitt commented Aug 8, 2024

Description

Noticed this error starting to appear:

Screenshot 2024-08-08 at 16 49 39

Seems to have been introduced in #1166 whereby the defaults are trying to be set, before Vuetify has fully loaded them, wbhich also meant #1166 never fully worked when delivered too.

@joepavitt joepavitt requested a review from gayanSandamal August 8, 2024 15:57
@joepavitt joepavitt marked this pull request as ready for review August 8, 2024 15:57
Copy link
Contributor

@gayanSandamal gayanSandamal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gayanSandamal gayanSandamal merged commit 74495e7 into main Aug 9, 2024
1 of 2 checks passed
@gayanSandamal gayanSandamal deleted the fix-theme-defaults branch August 9, 2024 04:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants