Alter alert subscription causing the vue application to silently crash #1301
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ribe when the child component mounts
joepavitt
approved these changes
Sep 17, 2024
joepavitt
deleted the
747_fix-ws-reactivity-caused-by-incorrect-component-lifecycle-mount-order
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The alerts service was subscribing in on the mounted lifecycle method in the Baseline.vue component (which is inherited by all existing layouts) before the UiNotification child component which it acted upot managed to properly mount.
Updated the lifecycle flow in order to preserve lifecycle consistency between parent/child components by forcing the alerts service to subscribe only after the UiNotification components get's mounted properly.
Related Issue(s)
closes #747
Checklist
flowforge.yml?FlowFuse/helmto update ConfigMap TemplateFlowFuse/CloudProjectto update values for Staging/ProductionLabels
area:migrationlabel