Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dropdown - emit msg on event #1458

Merged
merged 2 commits into from
Nov 29, 2024
Merged

Conversation

bartbutenaers
Copy link
Contributor

@bartbutenaers bartbutenaers commented Nov 11, 2024

Description

This PR adds a new option to the ui-dropdown node to select when an output message should be triggered:

image

As explained in the info panel:

image

This msgTrigger property can also be dynamically set. The default value is "onChange" like in the previous versions, to avoid breaking changes.

The following example flow demonstrates the default "onChange" value, which is then dynamically overwritten by a "onClose" value:

dropdown_emit

Related Issue(s)

Closes 1457

Checklist

  • I have read the contribution guidelines
  • Suitable unit/system level tests have been added and they pass
  • Documentation has been updated
    • Upgrade instructions
    • Configuration details
    • Concepts
  • Changes flowforge.yml?
    • Issue/PR raised on FlowFuse/helm to update ConfigMap Template
    • Issue/PR raised on FlowFuse/CloudProject to update values for Staging/Production

Labels

  • Includes a DB migration? -> add the area:migration label

@bartbutenaers
Copy link
Contributor Author

P.S. I used the @blur event, because @close was never triggered. See this discussion.

@joepavitt
Copy link
Collaborator

Thanks @bartbutenaers - great stuff.

Apart from a shift of where the form-row is in the config, and the labels used, this is good to go as far as I'm concerned. I'll be merging once the tests give me the green light.

@joepavitt joepavitt self-requested a review November 12, 2024 10:37
@joepavitt joepavitt merged commit 09b8d9b into FlowFuse:main Nov 29, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants