Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow RED.settings.ui as fallback settings for size #1540

Merged
merged 1 commit into from
Dec 18, 2024
Merged

Allow RED.settings.ui as fallback settings for size #1540

merged 1 commit into from
Dec 18, 2024

Conversation

hardillb
Copy link
Contributor

This is part of FlowFuse/flowfuse#4933

Description

Allows loading maxHttpBufferSize from RED.settings.ui as well RED.settings.dashboad

FF uses RED.settings.ui as the default.

Related Issue(s)

Checklist

  • I have read the contribution guidelines
  • Suitable unit/system level tests have been added and they pass
  • Documentation has been updated
    • Upgrade instructions
    • Configuration details
    • Concepts
  • Changes flowforge.yml?
    • Issue/PR raised on FlowFuse/helm to update ConfigMap Template
    • Issue/PR raised on FlowFuse/CloudProject to update values for Staging/Production

Labels

  • Includes a DB migration? -> add the area:migration label

@hardillb hardillb requested a review from joepavitt December 17, 2024 15:54
@hardillb hardillb self-assigned this Dec 17, 2024
hardillb added a commit to FlowFuse/nr-launcher that referenced this pull request Dec 17, 2024
@hardillb
Add Dashboard v2 max upload size
76a9baa 
part of FlowFuse/flowfuse#4933

needs FlowFuse/node-red-dashboard#1540
@hardillb hardillb mentioned this pull request Dec 17, 2024
Merged
10 tasks
@Steve-Mcl Steve-Mcl self-requested a review December 18, 2024 14:32
Steve-Mcl
Steve-Mcl approved these changes Dec 18, 2024
View reviewed changes
Copy link
Contributor

@Steve-Mcl Steve-Mcl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Steve-Mcl Steve-Mcl merged commit c9e45ff into main Dec 18, 2024
2 checks passed
@Steve-Mcl Steve-Mcl deleted the hardillb-patch-1 branch December 18, 2024 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Steve-Mcl Steve-Mcl Steve-Mcl approved these changes

@joepavitt joepavitt Awaiting requested review from joepavitt

Assignees

@hardillb hardillb

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hardillb @Steve-Mcl