Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add client data to nodes with multiple outputs #1542

Merged
merged 3 commits into from
Dec 18, 2024

Conversation

Steve-Mcl
Copy link
Contributor

Includes all of #1533 - but with linting fixes

Original description:

Description

When a UI-Node has multiple outputs, Node-RED sends an array of messages, with each message corresponding by index to the respective output of the node that should be triggered. The current Dashboard implementation for appending client data assumes that the message is not an array. As a result, the client data is added in the wrong place, causing issues.

Related Issue(s)

#1532

Checklist

  • I have read the contribution guidelines
  • Suitable unit/system level tests have been added and they pass
  • Documentation has been updated
    • Upgrade instructions
    • Configuration details
    • Concepts
  • Changes flowforge.yml?
    • Issue/PR raised on FlowFuse/helm to update ConfigMap Template
    • Issue/PR raised on FlowFuse/CloudProject to update values for Staging/Production

Labels

  • Includes a DB migration? -> add the area:migration label

@joepavitt joepavitt merged commit abf3130 into main Dec 18, 2024
2 checks passed
@joepavitt joepavitt deleted the fix-for-fix-client-data-for-multiple-outputs branch December 18, 2024 19:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants